Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ASM module add set gcloud.project.environProjectNumber #683

Closed
bharathkkb opened this issue Sep 21, 2020 · 2 comments · Fixed by #692
Closed

ASM module add set gcloud.project.environProjectNumber #683

bharathkkb opened this issue Sep 21, 2020 · 2 comments · Fixed by #692
Assignees
@bharathkkb
Labels
good first issue Good for newcomers P1 highest priority issues triaged Scoped and ready for work

Comments

@bharathkkb
Copy link
Member

ASM install now has an additional command kpt cfg set asm gcloud.project.environProjectNumber ${ENVIRON_PROJECT_NUMBER} that needs to added in script
@bharathkkb bharathkkb added good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work labels Sep 21, 2020
@therealmitchconnors
Copy link

Can we escalate this above P2? This is a hard blocker for using Terraform to install ASM.

@morgante morgante added P1 highest priority issues and removed P2 high priority issues labels Sep 29, 2020
@morgante
Copy link
Contributor

morgante commented Sep 29, 2020 •
edited

@bharathkkb Could you PTAL?

@therealmitchconnors We'd be happy to review a PR if you're able to contribute.

@bharathkkb bharathkkb self-assigned this Sep 29, 2020
@bharathkkb bharathkkb mentioned this issue Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bharathkkb bharathkkb

Labels
good first issue Good for newcomers P1 highest priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: set project number for ASM install terraform-google-modules/terraform-google-kubernetes-engine
3 participants
@therealmitchconnors @morgante @bharathkkb