beta-private-cluster-update-variant should generate new node pool ID if node_pools_taints is changed

[eripa]

beta-private-cluster-update-variant does not currently generate a new node pool random suffix is node_pools_taints is changed. This results in a name conflict error, like:

Error: error creating NodePool: googleapi: Error 409: Already exists: projects/example-project/locations/us-west4/clusters/cluster1/nodePools/default-node-pool-aa6d., alreadyExists

terraform-google-kubernetes-engine/modules/beta-private-cluster-update-variant/cluster.tf

Lines 294 to 348 in 26ea28d

	resource "random_id" "name" {
	for_each = local.node_pools
	byte_length = 2
	prefix = format("%s-", lookup(each.value, "name"))
	keepers = merge(
	zipmap(
	local.force_node_pool_recreation_resources,
	[for keeper in local.force_node_pool_recreation_resources : lookup(each.value, keeper, "")]
	),
	{
	labels = join(",",
	sort(
	concat(
	keys(local.node_pools_labels["all"]),
	values(local.node_pools_labels["all"]),
	keys(local.node_pools_labels[each.value["name"]]),
	values(local.node_pools_labels[each.value["name"]])
	)
	)
	)
	},
	{
	metadata = join(",",
	sort(
	concat(
	keys(local.node_pools_metadata["all"]),
	values(local.node_pools_metadata["all"]),
	keys(local.node_pools_metadata[each.value["name"]]),
	values(local.node_pools_metadata[each.value["name"]])
	)
	)
	)
	},
	{
	oauth_scopes = join(",",
	sort(
	concat(
	local.node_pools_oauth_scopes["all"],
	local.node_pools_oauth_scopes[each.value["name"]]
	)
	)
	)
	},
	{
	tags = join(",",
	sort(
	concat(
	local.node_pools_tags["all"],
	local.node_pools_tags[each.value["name"]]
	)
	)
	)
	}
	)
	}

[morgante]

Thanks, it just needs to be added here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/cluster.tf.tmpl#L333

Happy to review a PR.

[jinoobaek-qz]

Thanks, it just needs to be added here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/cluster.tf.tmpl#L333

Happy to review a PR.

Took a very naive stab at it. #717

[DrFaust92]

@apeabody can be closed

[apeabody]

Implemented in #717