Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: node_pool_taints available to all modules #705

Merged

Conversation

marko7460
Copy link
Contributor

This PR enables node pool taints on all the cluster types , not only beta clusters

@comment-bot-dev
Copy link

comment-bot-dev commented Oct 8, 2020

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante
Copy link
Contributor

morgante commented Oct 8, 2020

/gcbrun

@bharathkkb
Copy link
Member

/gcbrun

@marko7460 marko7460 force-pushed the enable-taints branch 2 times, most recently from d96b7dd to af0cd08 Compare October 9, 2020 05:40
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I do see some odd CI errors unrelated to this change, will take a look at them tomorrow.

test/setup/main.tf Show resolved Hide resolved
test/setup/main.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb changed the title node_pool_taints available to all modules feat: node_pool_taints available to all modules Oct 9, 2020
@bharathkkb bharathkkb merged commit 68e8eec into terraform-google-modules:master Oct 9, 2020
marko7460 added a commit to marko7460/terraform-google-kubernetes-engine that referenced this pull request Oct 10, 2020
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants