Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workload Identity: allow passing roles to created service account #708

Conversation

MeNsaaH
Copy link
Contributor

@MeNsaaH MeNsaaH commented Oct 9, 2020

Closes #694

@MeNsaaH MeNsaaH requested review from bharathkkb, Jberlinsky and a team as code owners October 9, 2020 16:01
@comment-bot-dev
Copy link

comment-bot-dev commented Oct 9, 2020

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

modules/workload-identity/main.tf Outdated Show resolved Hide resolved
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/cc @morgante

@morgante
Copy link
Contributor

Thanks for the contribution!

@morgante morgante merged commit e761dce into terraform-google-modules:master Oct 12, 2020
marko7460 pushed a commit to marko7460/terraform-google-kubernetes-engine that referenced this pull request Oct 13, 2020
bharathkkb added a commit that referenced this pull request Oct 14, 2020
* fix: promoting release_channel, database_encryption, workload_identity_config, and enable_shielded_nodes from beta to GA

* feat: allow passing roles to created Workload Identity service account (#708)

* Moving autoscaling from beta to GA

* Moving binary authorization from beta to GA

Co-authored-by: Mmadu Manasseh <mmadumanasseh@gmail.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…e-modules#709)

* fix: promoting release_channel, database_encryption, workload_identity_config, and enable_shielded_nodes from beta to GA

* feat: allow passing roles to created Workload Identity service account (terraform-google-modules#708)

* Moving autoscaling from beta to GA

* Moving binary authorization from beta to GA

Co-authored-by: Mmadu Manasseh <mmadumanasseh@gmail.com>
Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify roles that should be added to Service Account created for Workload identity
4 participants