Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wait-for-cluster fallback filter to name if location is not set #736

Merged
merged 1 commit into from
Nov 5, 2020
Merged

fix: wait-for-cluster fallback filter to name if location is not set #736

merged 1 commit into from
Nov 5, 2020

Conversation

bharathkkb
Copy link
Member

fixes #735

  • fallback to just using name in the filter if location is not set for destroy hook

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners November 3, 2020 21:13
@comment-bot-dev
Copy link

comment-bot-dev commented Nov 3, 2020 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 63d7f5e into master Nov 5, 2020
@bharathkkb bharathkkb deleted the fallback-wait-for-cluster branch November 5, 2020 04:30
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@bharathkkb
fix: fallback to name if location is not set (terraform-google-module…
e79fd2a 
…s#736)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local.location not set in wait-for-cluster.sh script
3 participants
@bharathkkb @comment-bot-dev @morgante