Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confidential computing #737

Closed
sudipju opened this issue Nov 6, 2020 · 9 comments
Closed

Confidential computing #737

sudipju opened this issue Nov 6, 2020 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work

Comments

@sudipju
Copy link

sudipju commented Nov 6, 2020

Hello,

We are using this module for the cluster creation for our project. We are planning to use some of our applications to be running with confidential computing. I didn't notice that support yet by this module. Could you please enlighten, in case you have some plan in near future.
Any response on this topic will be well appreciated !

Thanks,
Sudip

@bharathkkb
Copy link
Member

Hi @sudipju Looks like this will need to be added in the provider first

@bharathkkb bharathkkb added enhancement New feature or request upstream Work required on Terraform core or provider labels Nov 6, 2020
@bharathkkb
Copy link
Member

Looks like this was added in the latest release. Happy to review a PR to add this
GoogleCloudPlatform/magic-modules#4136

@bharathkkb bharathkkb added good first issue Good for newcomers P3 medium priority issues triaged Scoped and ready for work and removed upstream Work required on Terraform core or provider labels Nov 6, 2020
@sudipju
Copy link
Author

sudipju commented Nov 9, 2020

I observed that latest release is 12.0.0, which is released 24 days back. But, this specific change is merged 17 days back to master. Is there any beta release available after this merge? Not able to find the same. Or am I missing something?

As didn't see this variable in 12.0.0 version.
Thanks in advance.

@bharathkkb
Copy link
Member

So currently this feature was only added to the provider. In order to use it in the module, we need to make some changes to the source code in this repository. Here is an example PR of how to add a new feature to a beta module.

@sudipju
Copy link
Author

sudipju commented Nov 10, 2020

Thanks for the reply. I wait for this to be integrated in the source code repo. Is there any way to know the priority of this issue to be integrated? Or can our need be an influencer of the priority?
Thanks in advance.

@bharathkkb
Copy link
Member

@sudipju currently its best effort, but happy to review if you can open a PR

@bharathkkb bharathkkb added P2 high priority issues and removed P3 medium priority issues labels Jun 21, 2021
@AlfredHudson
Copy link

Is there any news about this issue?

@safag05
Copy link

safag05 commented Sep 23, 2021

@bharathkkb Is there an ETA on this?

@stenalpjolly
Copy link
Contributor

@bharathkkb Since we have added the beta support, can we close this issue?

@morgante morgante closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

6 participants