-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maintenance exclusions support #781
Add maintenance exclusions support #781
Conversation
633724a
to
013bb3c
Compare
Also to mention that we could improve this implementation when support to 0.12 is dropped and we could fully use variable validation for instance. Maintenance exclusion has some constraints or restrictions that I think we could address better with a higher terraform version. |
013bb3c
to
9bd0c60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @msgongora
You will need to bump the example provider versions as well. Example
We will also be dropping support for 0.12 in next release.
9bd0c60
to
646bd0d
Compare
646bd0d
to
68c6cb2
Compare
done, I see |
* Add support to maintenance exclusions * Bump google-beta required_providers to 3.49.0
* Add support to maintenance exclusions * Bump google-beta required_providers to 3.49.0
fixes #780
This feature has been GA for about a year but looking at the cluster template I realize most of the maintenance_policy features are still under beta, so I'm placing this PR under beta and probably I'm going to file another PR moving all those features, including this one, out of beta. Please let me know and I'll work on the 2nd PR as soon as I have time.