Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Provider v2 Support #816

Closed
Harjot1Singh opened this issue Feb 8, 2021 · 9 comments
Closed

Kubernetes Provider v2 Support #816

Harjot1Singh opened this issue Feb 8, 2021 · 9 comments
Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work

Comments

@Harjot1Singh
Copy link

Hi!

Any plans to support the new 2.x Kubernetes provider?

The upgrade path doesn't look too bad: https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs/guides/v2-upgrade-guide.

@bharathkkb
Copy link
Member

Hi @Harjot1Singh

Happy to review a PR with the update.

@bharathkkb bharathkkb added enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work labels Feb 8, 2021
@Harjot1Singh
Copy link
Author

Brilliant! Would you like me to version bump the module in the PR? Or will you cut the release separately?

@lhriley
Copy link

lhriley commented Apr 1, 2021

Curious if there has been any progress on this in the last ~2 months. The provider is still locked at 1.x:

kubernetes = {
source = "hashicorp/kubernetes"
version = "~> 1.10, != 1.11.0"

@morgante
Copy link
Contributor

morgante commented Apr 5, 2021

No progress as it's still on our backlog, but we'd be happy to review a PR.

@lhriley
Copy link

lhriley commented Apr 8, 2021

Unfortunately, I don't have the bandwidth to tackle all of the testing required before submitting a PR for this, or I would be more than happy to write something up.

@Harjot1Singh
Copy link
Author

I did fork and make the change to get the bare minimum running here: https://github.com/Harjot1Singh/terraform-google-kubernetes-engine

Haven't run it against the test criteria, but if Harjot1Singh@768d5b6 looks suitable then can PR it in. For other folks trying to get this to work meanwhile, set source = "github.com/Harjot1Singh/terraform-google-kubernetes-engine"

@morgante
Copy link
Contributor

@Harjot1Singh Thanks, those look to be along the lines of what we'd need but note the updates need to be made in autogen/ first.

@DrFaust92
Copy link
Contributor

@apeabody this can be closed

@apeabody
Copy link
Contributor

apeabody commented Aug 5, 2024

Updated in #892

@apeabody apeabody closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

6 participants