fix: Fix attribution for safer cluster modules #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgante
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
bharathkkb
reviewed
Feb 24, 2021
bharathkkb
approved these changes
Feb 24, 2021
bharathkkb
added a commit
that referenced
this pull request
Mar 11, 2021
bharathkkb
added a commit
that referenced
this pull request
Mar 12, 2021
* revert: Fix attribution for safer cluster modules (#830) * update to 14.0 * temporarily test with 0.14x tf image in ci * bump setup pf versions * bump setup provider * fix setup pf * kitchen fix for 0.14 * bump networking * bump iap example * switch back to 0.13 tests * fmt
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
* revert: Fix attribution for safer cluster modules (terraform-google-modules#830) * update to 14.0 * temporarily test with 0.14x tf image in ci * bump setup pf versions * bump setup provider * fix setup pf * kitchen fix for 0.14 * bump networking * bump iap example * switch back to 0.13 tests * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
_parent_modulevariable which can be used to pass parent module into the module attribution call, so we can track when parent modules are used and not just the base module.