feat!: Added support for multi-project GKE Hub registration #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an optional variable HUB_PROJECT_ID which will allow you to specific a seperate GCP project for the GKE HUB than the project the cluster is deployed to. This included updating the 3 examples the leveraged the hub module. Issue: terraform-google-modules#837
|
Thanks for the PR! 🚀 |
bharathkkb
reviewed
Mar 4, 2021
Ensuring that the Hub default Service Account exists when adding a cluster from outside the hub project Issue: terraform-google-modules#837
bharathkkb
reviewed
Mar 4, 2021
added 2 commits
March 4, 2021 15:52
bharathkkb
reviewed
Mar 5, 2021
There was a problem hiding this comment.
Overall LGTM
@JamesDuncanNz can you test an upgrade from previous hub version to this. There maybe a delete recreate op as we are changing create_cmd_gke_body and would be good to capture this in the upgrade guide as it may result in the de registration and subsequent registration during upgrade.
bharathkkb
approved these changes
Mar 9, 2021
bharathkkb
changed the title
Merged
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…m-google-modules#840) * Added support for multi-project GKE Hub registration Added an optional variable HUB_PROJECT_ID which will allow you to specific a seperate GCP project for the GKE HUB than the project the cluster is deployed to. This included updating the 3 examples the leveraged the hub module. Issue: terraform-google-modules#837 * Adding service idenity resource for multi project deployments Ensuring that the Hub default Service Account exists when adding a cluster from outside the hub project Issue: terraform-google-modules#837 * Fixing bharathkkb comments Fixes terraform-google-modules#837 * Fix linting issue * Removed Google project data souce Issue: terraform-google-modules#837 * Adding upgrade documentation for this change. * Lint updates on readme. Co-authored-by: James Duncan <jdun@google.com> Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional variable HUB_PROJECT_ID which will allow you to specific a seperate
GCP project for the GKE HUB than the project the cluster is deployed to.
This included updating the 3 examples the leveraged the hub module.
Fixes #837