feat: Default image type for gke sandbox #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolnasc
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
morgante
suggested changes
Mar 24, 2021
There was a problem hiding this comment.
Please make sure that modules are generated from autogen templates:
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/cluster.tf /tmp/tmp.I6Ocwbpd7l/workspace/cluster.tf
236c236
< image_type = lookup(each.value, "image_type", "COS")
---
> image_type = lookup(each.value, "image_type", var.sandbox_enabled ? "COS_CONTAINERD" : "COS")
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/private-cluster/cluster.tf /tmp/tmp.I6Ocwbpd7l/workspace/modules/private-cluster/cluster.tf
249c249
< image_type = lookup(each.value, "image_type", "COS")
---
> image_type = lookup(each.value, "image_type", var.sandbox_enabled ? "COS_CONTAINERD" : "COS")
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' /workspace/modules/private-cluster-update-variant/cluster.tf /tmp/tmp.I6Ocwbpd7l/workspace/modules/private-cluster-update-variant/cluster.tf
333c333
< image_type = lookup(each.value, "image_type", "COS")
---
> image_type = lookup(each.value, "image_type", var.sandbox_enabled ? "COS_CONTAINERD" : "COS")
Error: submodule's files generation has not been run, please run the
Oh, that's right. |
|
/gcbrun |
morgante
approved these changes
Mar 24, 2021
|
@diegolnasc Thanks for the PR! 🚀 |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.