-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hub module with native resources #860
Comments
Semi-related issue: the registration scripts have dependencies on Those dependencies make running a containerized Terraform instance harder. (i.e. you cannot use the hashicorp/terraform image as it is). |
@ferrarimarco happy to review a PR to replace the resources with native ones |
Sure. I may be able to help, but I think we need to design this a bit, it looks a bit wider-scoped than my first PR (#886). 😄 Here's an example that uses the native gke_hub_membership (note that for
If I'm not mistaken, the native resource relies on workload identity, more than using the (downloaded) key of a service account. This might introduce a breaking change with the existing module. Is forward compatibility something we should aim for? In terms of semantic versioning, users might expect that because the |
I am currently experiencing issues with getting this TF native resource to work. I had been using the Google CFT module for anthos registration and it worked fine, but in order to remove the gcloud dependency I've been trying to switch over. When using the TF resource I notice that the TF runs successfully with no errors.... but the gke-connect-agent deployment does not exist on the GKE cluster, and the gke-connect namespace does not exist either. As a result the Anthos dashboard is showing me errors saying "Unable to reach Connect Agent". QUESTIONS: |
@walkernobrien The native resource actually works differently (without the Connect Agent). If you're getting an error, I suggest opening a support case with Google. |
/cc @r4hulgupta who was also investigating the native resource |
We should replace provisioners in our module now that there is native support
GoogleCloudPlatform/magic-modules#4600
The text was updated successfully, but these errors were encountered: