Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the use of a service account to install ASM with the module #879

Closed
alexbrand-au opened this issue Apr 27, 2021 · 5 comments
Closed
Labels

Comments

@alexbrand-au
Copy link

In our terraform setup, we configure the google and google-beta providers to use a service account access token to interact with the GCP APIs:

provider "google" {
  access_token = data.google_service_account_access_token.default.access_token
}

provider "google-beta" {
  access_token = data.google_service_account_access_token.default.access_token
}

Ideally, the ASM module would impersonate this service account as well during the ASM installation. However, this does not seem to be the case, given that the module shells out to the gcloud CLIs, which are not guaranteed to be configured with the service account (e.g. they are configured with personal accounts).

@alexbrand-au
Copy link
Author

Related to #874

@yashbhutwala
Copy link
Contributor

@alexbrand-au I did add impersonate_service_account to the asm module as part of this. Hopefully, it resolves the issue for you as well 😃

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jul 20, 2021
@bharathkkb
Copy link
Member

This should now be possible via

variable "impersonate_service_account" {

@ignaciojcano
Copy link

Was this removed in newer versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants