Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce flag add_master_webhook_firewall_rules #882

Merged

Conversation

fstr
Copy link
Contributor

@fstr fstr commented Apr 29, 2021

Resolves #880

  • Flag controls exclusive creation of a firewall rule for ports defined in firewall_inbound_ports
  • The existing flag add_cluster_firewall_rules is kept on the firewall rule resource for backwards compatibility

- Flag controls exclusive creation of a firewall rule for ports defined in firewall_inbound_ports
- The existing flag add_cluster_firewall_rules is kept on the firewall rule resource for backwards compatibility
@fstr fstr requested review from bharathkkb, Jberlinsky and a team as code owners April 29, 2021 20:19
@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante morgante merged commit 8a5dcb8 into terraform-google-modules:master Apr 29, 2021
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
terraform-google-modules#882)

- Flag controls exclusive creation of a firewall rule for ports defined in firewall_inbound_ports
- The existing flag add_cluster_firewall_rules is kept on the firewall rule resource for backwards compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one flag for two unrelated additional firewall rules
3 participants