Updated ASM terraform module for 1.8 and 1.9 #895
Conversation
|
Thanks for the PR! 🚀 |
| default = "1.9" | ||
| } | ||
|
|
||
| variable "asm_git_tag" { |
There was a problem hiding this comment.
Do we really need to expose this level of detail? It's a bit concerning if customers are having to separately version the install script from ASM.
There was a problem hiding this comment.
Yes, this is a feedback directly from Lifecycle eng
| default = "" | ||
| } | ||
|
|
||
| variable "mode" { |
There was a problem hiding this comment.
If a variable has only one acceptable value, it shouldn't be a variable.
There was a problem hiding this comment.
This will soon change to also support upgrade
| default = "install" | ||
| } | ||
|
|
||
| variable "service_account" { |
There was a problem hiding this comment.
Do we need to use a service account to authenticate? I'd prefer if we use whatever credentials Terraform is running as (Application Default Credentials).
Downloading service account keys should not be encouraged.
There was a problem hiding this comment.
I agree. The install_asm script supports it as an option and this was a feedback from a partner.
…-modules#895) * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module * updated asm module Co-authored-by: coder <coder@google.com> Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
This is a major update to the current ASM terraform module with the following updates:
installandupgrademode (upgrades supports deploying the new control plane only).install_asmscript.skip_validationfor CI systems where you dont want the script to perform validation checks.install_asmscript (for example1.8.2-asm.2+config2).