Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch ASM enable api, iam flags to native resources #914

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

bharathkkb
Copy link
Member

fixes #905

enable_gcp_components seems to modify update the cluster, so leaving it as is.

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners June 1, 2021 04:22
@comment-bot-dev
Copy link

comment-bot-dev commented Jun 1, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb
Copy link
Member Author

/cc @ameer00 @cloud-pharaoh

@cloud-pharaoh
Copy link
Contributor

I am 100% for using native TF resources rather than bash scripts hidden under TF modules. However, in this case, this module is a wrapper around install_asm.sh. I am concerned that now the burden of maintenance is higher than before where a subset of functionality (albeit minimal with APIs and IAM roles) is in TF and the rest in the script.
I personally think that keeping it as simply a wrapper and letting the script decide if/when to create/destroy/recreate resources with the logic implemented there rather than selecting a flag that would make the module behave inconsistently because some of the functionality is extracted.

@morgante
Copy link
Contributor

morgante commented Jun 2, 2021

My view is that we should only use bash scripts where we need to. Ideally we would eventually throw away the underlying script entirely. This is the approach we have successfully taken with project-factory and I'd like to take it here.

Obviously this does increase the maintenance burden but in general I would rather do that than continue to use a massive bash script which re-implements logic that Terraform should be doing.

@morgante morgante merged commit ff71123 into master Jun 3, 2021
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASM Module: Replace script components with native resources
4 participants