Fixed the ASM module's destroy command. #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
morgante
approved these changes
Jun 4, 2021
Closed
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…ts (terraform-google-modules#918) Co-authored-by: Maarten Baijs <mbaijs@harlemnext.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ASM module’s destroy command only removes the istio-system namespace. This pull request extends the module’s destroy command to remove any istio/asm related labels and/or namespaces.
For testing my changes, I used the "simple_zonal_with_asm" example. Unfortunately, the example didn't start due to the ca_certificate output variable not being marked as sensitive. After correcting this mistake, everything was working as expected.
Fixes #881