Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asm destroy #922

Merged
merged 2 commits into from
Jun 7, 2021
Merged

fix: asm destroy #922

merged 2 commits into from
Jun 7, 2021

Conversation

bharathkkb
Copy link
Member

fixes #919
also adds --ignore-not-found incase a namespace is not found. This could be useful if destroy failed midway due to any reason and only removed one of the namespaces.

@bharathkkb bharathkkb requested review from Jberlinsky and a team as code owners June 7, 2021 18:28
@comment-bot-dev
Copy link

comment-bot-dev commented Jun 7, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit f3ddbf5 into master Jun 7, 2021
@bharathkkb bharathkkb deleted the fix-asm-destroy branch June 7, 2021 20:55
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
* fix: asm destroy

* fix nodepool test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASM destroy failing
3 participants