Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove kustomize requirement #930

Merged

Conversation

stepanstipl
Copy link
Contributor

kustomize seems to be a historical requirement, and is not used anymore by the ASM install script - https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/modules/asm/scripts/install_asm.sh.

The install works fine without kustomize command being available on the system.

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @stepanstipl
Failure seems unrelated

@bharathkkb bharathkkb merged commit 389521b into terraform-google-modules:master Jun 14, 2021
@yonicurv
Copy link

Hey,

Is there any timeline for publishing a release containing this PR ?

Any info would be appreciated.
Thx.

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants