Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform-google-kubernetes-engine 16.0 forces replacement of existing workload-identities #959

Closed
vfiset opened this issue Jul 23, 2021 · 2 comments · Fixed by #960
Closed

Comments

@vfiset
Copy link

vfiset commented Jul 23, 2021

While upgrading terraform-google-kubernetes-engine from 15.0.2 to 16.0, all the workload-indentities that are already existing are flagged as to be replaced by a terraform plan.

@vfiset vfiset changed the title terraform-google-kubernetes-engine forces replacement of existing workload-identities terraform-google-kubernetes-engine 16.0 forces replacement of existing workload-identities Jul 23, 2021
@bharathkkb
Copy link
Member

Thanks for the report @vfiset

I think this may have been due to the resource rename in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/pull/955/files from resource "google_service_account" "cluster_service_account" to resource "google_service_account" "main". I'll test a repro, if you have logs that would be useful.

@bharathkkb
Copy link
Member

@vfiset I was able to repro and reverting the resource name back prevents replacement. PR #960 with fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants