Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider k8s service account name from evaluated local parameter #972

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

sig-abyreddy
Copy link
Contributor

Module supports providing a custom name for kubernetes service account through k8s_sa_name variable. But internally this value is not considered for kubernetes service account resource.

k8s_given_name has evaluated value for service account name under locals. Using this value will respect custom input from the user.

@google-cla
Copy link

google-cla bot commented Aug 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@sig-abyreddy
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure is unrelated.

@morgante morgante merged commit e00286f into terraform-google-modules:master Aug 11, 2021
@sig-abyreddy
Copy link
Contributor Author

Thank for accepting the MR @morgante

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants