Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NoExecute instead of NO_EXECUTE in node pool #152

Closed
arthurgustin opened this issue May 21, 2019 · 3 comments
Closed

Use NoExecute instead of NO_EXECUTE in node pool #152

arthurgustin opened this issue May 21, 2019 · 3 comments

Comments

@arthurgustin
Copy link

When creating nodepool with taints, I'd expect writing NoExecute as stated in the doc https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/

But it throws in the console:

expected node_config.0.taint.0.effect to be one of [NO_SCHEDULE PREFER_NO_SCHEDULE NO_EXECUTE], got NoExecute
@morgante
Copy link
Contributor

Can you clarify what the issue is here? I don't think it's a bug in this module.

@arthurgustin
Copy link
Author

It's not an issue, just something I find inconsistent

@morgante
Copy link
Contributor

Got it, I think it's an upstream issue with the provider and/or GKE API rather than this module.

@EronWright EronWright mentioned this issue Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@morgante @arthurgustin