Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for TCP healthcheck #346

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

ps-occrp
Copy link
Contributor

This adds support for TCP health checks and fixes #129 , #258 and #272

@ps-occrp ps-occrp requested review from imrannayer and a team as code owners August 10, 2023 10:39
@google-cla
Copy link

google-cla bot commented Aug 10, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ps-occrp ps-occrp force-pushed the ps-occrp-patch-1 branch 2 times, most recently from 35baf65 to 135ed17 Compare August 10, 2023 10:45
@imrannayer imrannayer changed the title Add support for TCP healthcheck feat: Add support for TCP healthcheck Aug 10, 2023
@imrannayer
Copy link
Collaborator

@ps-occrp can you plz add it to autogen and execute make build?
You can find details on contribution guidelines here

@ps-occrp
Copy link
Contributor Author

@imrannayer done! Thanks for the hint!

Add support for tcp health check
@imrannayer
Copy link
Collaborator

imrannayer commented Aug 11, 2023

@ps-occrp seems like tcp_health_check block hasrequest, response, port_name, proxy_header and port_specification. Can you plz add them in backends variable healthcheck section as optional and use them?
It seems like we are also missing healthcheck parameters for other healthcheck. Can you plz add them too?

Add support for extra parameters
@ps-occrp
Copy link
Contributor Author

@imrannayer Thanks for picking this, I have added this parameters.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

@ps-occrp can u also add parameters in variables.tf file.

Add support for all optional health check fields for different checks
@ps-occrp
Copy link
Contributor Author

@imrannayer done, I have additionally added optional missing parameters in other types of health checks to keep them all in sync.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit ddddf32 into terraform-google-modules:master Aug 14, 2023
4 checks passed
@ps-occrp ps-occrp deleted the ps-occrp-patch-1 branch April 19, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use "TCP" health check with http load balancer.
2 participants