Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Server TLS Policy parameter #387

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

bnounours
Copy link
Contributor

Hello,

In my infra we put in place mTLS authentication on the load balancer. For that we declared a google_certificate_manager_trust_config and a google_network_security_server_tls_policy. To make the link I added server_tls_policy to module and used it in google_compute_target_https_proxy

Thanks to this modification I now have a Load Balancer SSL with mTLS

@bnounours bnounours requested review from imrannayer and a team as code owners November 21, 2023 09:24
Copy link

google-cla bot commented Nov 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bnounours bnounours changed the title Server TLS Policy feat: Server TLS Policy Nov 21, 2023
@bnounours bnounours changed the title feat: Server TLS Policy feat: Add Server TLS Policy parameter Nov 21, 2023
@imrannayer
Copy link
Collaborator

@bnounours thx for the PR. Can you plz follow the document and make this change in autogen.

Thanks

@bnounours
Copy link
Contributor Author

bnounours commented Nov 27, 2023

Hello,
I launched the make build to generate the doc and the modules => Ok
I launched the make docker_test_lint => Ok but do not generate anything so we don't see it in the repo.
I did not luanch make docker_test_prepare as I don't have the right in my company to create project and set billing account

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit c553947 into terraform-google-modules:master Nov 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants