Enable users to control if firewall rules for health check are created #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! 🚀 |
Mahsamtm
previously approved these changes
Jul 14, 2021
morgante
suggested changes
Jul 14, 2021
variables.tf
Outdated
| type = bool | ||
| } | ||
|
|
||
| variable "create_healtcheck_firewall" { |
There was a problem hiding this comment.
Suggested change
| variable "create_healtcheck_firewall" { | |
| variable "create_health_check_firewall" { |
There was a problem hiding this comment.
Thanks for the answer. I did that, but all of them are skipped. I don't see any changes to the PR afterwards:
Generating markdown docs with terraform-docs
Working in . ...
Success!
Skipping ./examples/minimal because README.md does not exist.
Working in ./examples/simple ...
Success!
Skipping ./test/fixtures/minimal because README.md does not exist.
Skipping ./test/setup because README.md does not exist.
There was a problem hiding this comment.
Isn't it because this module doesn't really have a table with variables in readme?
There was a problem hiding this comment.
You're right, looks like you're fine.
There was a problem hiding this comment.
@morgante so you are good to give it 👍 ?
morgante
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module currently forces user to create firewall rules for health check. This PR changes that behavior adding new variable to control if firewall rules are created for health checks with default set to
trueand proper comment explaining the implications of setting it differently.Motivation behind opening this configuration option is scenario where load-balancer is created in shared network and project creating it doesn't have access to manipulate firewall rules.