feat!: Adds support for labels #96
Conversation
|
Thanks for the PR! 🚀 |
main.tf
Outdated
| @@ -28,6 +28,7 @@ data "google_compute_subnetwork" "network" { | |||
| } | |||
|
|
|||
| resource "google_compute_forwarding_rule" "default" { | |||
| provider = google-beta | |||
There was a problem hiding this comment.
I was doing some more digging and it seemed to me like the regular provider may actually support this but it is not documented. Did you try this with the regular provider before using beta?
https://github.com/hashicorp/terraform-provider-google/blob/922b67a420efa3bfabde02dd097ef1e1d68d7316/google/resource_compute_forwarding_rule.go#L289
There was a problem hiding this comment.
I just tested and confirmed that forwarding rules support labels without the beta provider, so I've removed the provider attribute from that resource. These docs may be slightly out of date: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_forwarding_rule#labels
The health checks do still require the beta provider, so I'll keep it in versions.tf.
There was a problem hiding this comment.
We are currently using provider version >= 3.53, < 5.0, which does not contain label support outside of beta. Should we bump our version (to >= 4.26, < 5.0), or leave the beta provider on the forwarding rule resource for now?
There was a problem hiding this comment.
@willroberts Lets bump the version to 4.26
There was a problem hiding this comment.
Thanks @willroberts - It looks like you will need to (at least) also bump
to3.1 to support the TPG4 requirement.
There was a problem hiding this comment.
Still looking at this; the instance_template dependency also needed to be updated, and I'm tracking down some additional sources of provider < 4.0.0 constraints.
The terraform_validate steps in make docker_test_lint appear to be installing provider 3.62.0 and beta provider 3.90.1.
There was a problem hiding this comment.
Got this working locally. /usr/local/bin/terraform_validate in the container uses terraform init -backend=false. Adding -upgrade to the arguments resolved the dependencies successfully.
Looks like it's also passing in CI now.
No description provided.