Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support/Allow Terraform 0.13 #196

Closed
jai opened this issue Aug 11, 2020 · 2 comments · Fixed by #197
Closed

Support/Allow Terraform 0.13 #196

jai opened this issue Aug 11, 2020 · 2 comments · Fixed by #197

Comments

@jai
Copy link

jai commented Aug 11, 2020 •
edited

Hi all - currently this module is semver-locked to Terraform 0.12.6, are we able to relax this to allow 0.13 or are there any known breaking changes? Happy to contribute/help out as needed.
@morgante
Copy link
Contributor

If you're able to test with Terraform 0.13 we're happy to accept a PR. Similar PR example: terraform-google-modules/terraform-google-kubernetes-engine#621

@bharathkkb
Copy link
Member

I have this staged from when I did the other modules. Will send a PR soon.

@bharathkkb bharathkkb mentioned this issue Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: relax tf version to allow 0.13 terraform-google-modules/terraform-google-network
3 participants
@morgante @jai @bharathkkb