Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set firewall logging for each rule #236

Merged
merged 2 commits into from
Feb 2, 2021
Merged

fix: Set firewall logging for each rule #236

merged 2 commits into from
Feb 2, 2021

Conversation

bgdanix
Copy link
Contributor

@bgdanix bgdanix commented Feb 2, 2021

With the current version, it is not possible to enable firewall logs. This PR fixes the issue by changing the firewall module to look at the extra_attributes inside the custom_rules var when dynamically building the log_config.
Variable types have also been updated (where it made sense) for fabric-net-firewall module.

@bgdanix bgdanix requested a review from a team February 2, 2021 10:12
@comment-bot-dev
Copy link

comment-bot-dev commented Feb 2, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bgdanix bgdanix requested a review from a team as a code owner February 2, 2021 11:26
morgante
morgante approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@morgante morgante merged commit 2f44790 into terraform-google-modules:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgdanix @comment-bot-dev @morgante