feat: add metadata_fields support #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
/gcbrun |
|
@d-costa can u plz add the changes in subnets-beta module |
d-costa
force-pushed
the
master
branch
2 times, most recently
from
8056932
to
1a76c93
Compare
|
/gcbrun |
|
@imrannayer what's causing the linting error?
|
|
@d-costa metadata_fields is list of strings. You are using string. |
|
/gcbrun |
|
@d-costa Integration test is failing with following error: |
|
david@[host] in terraform-google-network on master $ make docker_test_integration
docker run --rm -it \
-e SERVICE_ACCOUNT_JSON \
-v /home/david/code/terraform-google-network:/workspace \
gcr.io/cloud-foundation-cicd/cft/developer-tools:1.13 \
/usr/local/bin/test_integration.sh
Activated service account credentials for: [myserviceaccount.iam.gserviceaccount.com]
Automatically setting inputs from outputs of test/setup
Activated service account credentials for: [ci-network@ci-network-0224.iam.gserviceaccount.com]
-----> Starting Test Kitchen (v3.5.0)
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::UserError
>>>>>> Message: Kitchen YAML file /workspace/kitchen.yml does not exist.
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration
-----> Starting Test Kitchen (v3.5.0)
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::UserError
>>>>>> Message: Kitchen YAML file /workspace/kitchen.yml does not exist.
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration
make: *** [Makefile:58: docker_test_integration] Error 20Kitchen's log contains: |
|
/gcbrun |
|
@d-costa Integration test is failing |
|
@d-costa you can execute test locally as follows Generate list of all the testsRun a test TestPrivateServiceConnect |
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
imrannayer
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metadata_fieldsto thelog_configblock of subnets submoduleNote:
subnetsvariable type fromlist(map(string))tolist(object{...}), to allow heterogeneous types.