-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add metadata_fields support #467
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/gcbrun |
@d-costa can u plz add the changes in subnets-beta module |
8056932
to
1a76c93
Compare
/gcbrun |
@imrannayer what's causing the linting error?
|
@d-costa metadata_fields is list of strings. You are using string. |
/gcbrun |
@d-costa Integration test is failing with following error:
|
david@[host] in terraform-google-network on master $ make docker_test_integration
docker run --rm -it \
-e SERVICE_ACCOUNT_JSON \
-v /home/david/code/terraform-google-network:/workspace \
gcr.io/cloud-foundation-cicd/cft/developer-tools:1.13 \
/usr/local/bin/test_integration.sh
Activated service account credentials for: [myserviceaccount.iam.gserviceaccount.com]
Automatically setting inputs from outputs of test/setup
Activated service account credentials for: [ci-network@ci-network-0224.iam.gserviceaccount.com]
-----> Starting Test Kitchen (v3.5.0)
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::UserError
>>>>>> Message: Kitchen YAML file /workspace/kitchen.yml does not exist.
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration
-----> Starting Test Kitchen (v3.5.0)
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::UserError
>>>>>> Message: Kitchen YAML file /workspace/kitchen.yml does not exist.
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration
make: *** [Makefile:58: docker_test_integration] Error 20 Kitchen's log contains: |
/gcbrun |
@d-costa Integration test is failing
|
@d-costa you can execute test locally as follows
Generate list of all the tests
Run a test TestPrivateServiceConnect
|
/gcbrun |
2 similar comments
/gcbrun |
/gcbrun |
metadata_fields
to thelog_config
block of subnets submoduleNote:
subnets
variable type fromlist(map(string))
tolist(object{...})
, to allow heterogeneous types.