Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add stack type to peering module #500

Merged
merged 2 commits into from
Oct 3, 2023
Merged

feat: add stack type to peering module #500

merged 2 commits into from
Oct 3, 2023

Conversation

mmorejon
Copy link
Contributor

@mmorejon mmorejon commented Oct 2, 2023

Add stack_type variable to the network-peering module.

The stack_type value will be added to local and peer resources.

Link to the stack_type field in google provider.

@mmorejon mmorejon requested review from imrannayer and a team as code owners October 2, 2023 13:11
@imrannayer
Copy link
Collaborator

@mmorejon thanks for the PR. stack_type was released in version 4.65. Can you plz update versions.tf in peering module with >= 4.65 for both google and google-beta provider?

version = "<5.0,>= 4.65"

@mmorejon mmorejon force-pushed the add-stack-type-to-network-peering-module branch from 3617a07 to 63b07fd Compare October 2, 2023 14:02
@mmorejon
Copy link
Contributor Author

mmorejon commented Oct 2, 2023 •
edited
Loading

good catch @imrannayer ! fixed.

@mmorejon mmorejon force-pushed the add-stack-type-to-network-peering-module branch from 389b3e9 to 110775e Compare October 2, 2023 14:06
@imrannayer
Copy link
Collaborator

/gcbrun

@mmorejon
feat: add stack type to peering module
9ef4869 
Signed-off-by: Manuel Morejon <manuel@mmorejon.io>
@mmorejon
change version constraint format
2de6e55 
Signed-off-by: Manuel Morejon <manuel@mmorejon.io>
@mmorejon mmorejon force-pushed the add-stack-type-to-network-peering-module branch from 57e7662 to 2de6e55 Compare October 2, 2023 18:21
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer self-requested a review October 3, 2023 14:22
@imrannayer imrannayer merged commit bc711d2 into terraform-google-modules:master Oct 3, 2023
4 checks passed
@release-please release-please bot mentioned this pull request Oct 3, 2023
Merged
@mmorejon mmorejon deleted the add-stack-type-to-network-peering-module branch October 3, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imrannayer imrannayer imrannayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorejon @imrannayer