-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stack type to peering module #500
Merged
imrannayer
merged 2 commits into
terraform-google-modules:master
from
mmorejon:add-stack-type-to-network-peering-module
Oct 3, 2023
Merged
feat: add stack type to peering module #500
imrannayer
merged 2 commits into
terraform-google-modules:master
from
mmorejon:add-stack-type-to-network-peering-module
Oct 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mmorejon thanks for the PR.
|
3617a07
to
63b07fd
Compare
good catch @imrannayer ! fixed. |
389b3e9
to
110775e
Compare
imrannayer
reviewed
Oct 2, 2023
imrannayer
reviewed
Oct 2, 2023
/gcbrun |
Signed-off-by: Manuel Morejon <manuel@mmorejon.io>
Signed-off-by: Manuel Morejon <manuel@mmorejon.io>
57e7662
to
2de6e55
Compare
/gcbrun |
imrannayer
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
stack_type
variable to thenetwork-peering
module.The
stack_type
value will be added tolocal
andpeer
resources.Link to the
stack_type
field in google provider.