Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update null and random providers #228

Merged
merged 4 commits into from
Jun 22, 2021
Merged

Update null and random providers #228

merged 4 commits into from
Jun 22, 2021

Conversation

fboula
Copy link
Contributor

@fboula fboula commented Jun 22, 2021 •
edited
Loading

Fix issue

#227

Context

  • Update hashicorp/null and hashicorp/random providers to 3.1.0 to keep up with providers updates.
  • Remove provider constraints from fixtures since providers versions are pinned with required_provider

@comment-bot-dev
Copy link

comment-bot-dev commented Jun 22, 2021 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@fboula fboula force-pushed the chore/update-providers branch 2 times, most recently from 63d0e61 to 5f6965f Compare June 22, 2021 20:08
morgante
morgante suggested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to fix fixtures (or just remove version constraints from them).

@fboula
Copy link
Contributor Author

fboula commented Jun 22, 2021

@morgante I just updated the provider version in the fixtures. But I am not sure they should be kept since the required_provider already enforce this at module level. WDYT ?

@morgante
Copy link
Contributor

@morgante I just updated the provider version in the fixtures. But I am not sure they should be kept since the required_provider already enforce this at module level. WDYT ?

I'm fine with removing them.

@morgante morgante merged commit 21d3771 into terraform-google-modules:master Jun 22, 2021
@fboula fboula deleted the chore/update-providers branch June 22, 2021 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fboula @comment-bot-dev @morgante