-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add depends on replicas for user creation #268
fix: add depends on replicas for user creation #268
Conversation
Thanks for the PR! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not use timeouts for this. That's not the right fix.
If there are issues with parallelism, the correct fix is to adjust the depends_on
so it doesn't start until the earlier resources are done.
We should never expose timeout parameters to users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do this for mysql too
@bharathkkb - I can do that as another PR. Let's let this go through to unblock the customer for now. |
@g-awmalik Can you add this for mysql and mssql? I want to get those into the release. |
@morgante - this includes the change for MySql as well. However, this module doesn't include replica setup for MSSQL yet. I can work on that but we may want to push these changes for now. |
This is an interim fix for this issue
Additionally, it uses the custom machine types for the postgresql examples since the shared instance was taking too long and timing out.