-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing google-beta provider to required_providers #282
Add missing google-beta provider to required_providers #282
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @amir-hadi
Looks like we are also missing it for mysql module https://github.com/terraform-google-modules/terraform-google-sql-db/blob/master/modules/mysql/versions.tf
google-beta = { | ||
source = "hashicorp/google-beta" | ||
version = ">= 4.4.0, < 5.0" | ||
} | ||
} | ||
|
||
provider_meta "google" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also add provider_meta for the beta provider?
terraform-google-sql-db/modules/mssql/versions.tf
Lines 27 to 29 in 704be5d
provider_meta "google-beta" { | |
module_name = "blueprints/terraform/terraform-google-sql-db:mssql/v10.0.0" | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharathkkb I am not sure what provider_meta does, but I did basically copy & paste it to the right place (I hope!).
@bharathkkb I also added it for mySQL now. |
@amir-hadi |
You are using the google-beta provider in
main.tf
, but it's not declared in therequired_providers
block, which creates a warning on each run.