Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing google-beta provider to required_providers #282

Merged
merged 5 commits into from
Mar 16, 2022
Merged

Add missing google-beta provider to required_providers #282

merged 5 commits into from
Mar 16, 2022

Conversation

amir-hadi
Copy link
Contributor

You are using the google-beta provider in main.tf, but it's not declared in the required_providers block, which creates a warning on each run.

@google-cla
Copy link

google-cla bot commented Mar 9, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

google-beta = {
source = "hashicorp/google-beta"
version = ">= 4.4.0, < 5.0"
}
}

provider_meta "google" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add provider_meta for the beta provider?

provider_meta "google-beta" {
module_name = "blueprints/terraform/terraform-google-sql-db:mssql/v10.0.0"
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharathkkb I am not sure what provider_meta does, but I did basically copy & paste it to the right place (I hope!).

@amir-hadi
Copy link
Contributor Author

@bharathkkb I also added it for mySQL now.

@comment-bot-dev
Copy link

@amir-hadi
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 714428c into terraform-google-modules:master Mar 16, 2022
@amir-hadi amir-hadi deleted the add-missing-google-beta-provider branch March 19, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants