Create SQL Backup and export module #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
reviewed
May 4, 2022
There was a problem hiding this comment.
Thanks for the PR @gleichda
Can you also add a usage example in https://github.com/terraform-google-modules/terraform-google-sql-db/tree/master/examples and a test if possible?
gleichda
force-pushed
the
sql-backup
branch
8 times, most recently
from
1f18b57 to
e49a5d7
Compare
…m-google-sql-db into sql-backup
…m-google-sql-db into sql-backup
gleichda
force-pushed
the
sql-backup
branch
3 times, most recently
from
0d6bc27 to
d68605c
Compare
bharathkkb
reviewed
May 12, 2022
.../integration/mysql-backup-create-service-account/mysql_backup_create_service_account_test.go
Outdated
Show resolved
Hide resolved
bharathkkb
previously approved these changes
May 13, 2022
|
@gleichda |
bharathkkb
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a module that uses google workflows for creating scheduled on-demand backups and exports to GCS fro CloudSQL instances.
Tests and examples to follow but first I want to get confirmation that this repo is right to add this module.