Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a description variable for google_compute_global_address resource #299

Merged
merged 3 commits into from
May 9, 2022
Merged

Add a description variable for google_compute_global_address resource #299

merged 3 commits into from
May 9, 2022

Conversation

kpocius
Copy link
Contributor

@kpocius kpocius commented May 8, 2022

To allow importing existing resources into the module as missing description forces a replacement.

@google-cla
Copy link

google-cla bot commented May 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@comment-bot-dev
Copy link

@kpocius
Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @kpocius

@bharathkkb bharathkkb merged commit fe91aa5 into terraform-google-modules:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants