Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add support for settings.active_directory_config for SQL module #305

Merged
merged 5 commits into from
May 25, 2022

Conversation

vponnam
Copy link
Contributor

@vponnam vponnam commented May 24, 2022

This change beings support for connecting SQL servers to Managed AD domain.

New feature available in v4.22.0 provider

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vponnam

modules/mssql/variables.tf Outdated Show resolved Hide resolved
bharathkkb
bharathkkb previously approved these changes May 25, 2022
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you also bump the min provider version here?

version = ">= 4.4.0, < 5.0"

@bharathkkb bharathkkb changed the title add support for settings.active_directory_config for SQL module feat!: add support for settings.active_directory_config for SQL module May 25, 2022
@comment-bot-dev
Copy link

@vponnam
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 449f1a2 into terraform-google-modules:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants