Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for availability_type in read replica configuration #328

Closed
enocom opened this issue Aug 2, 2022 · 4 comments
Closed

Add support for availability_type in read replica configuration #328

enocom opened this issue Aug 2, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request P2 high priority issues triaged Scoped and ready for work

Comments

@enocom
Copy link

enocom commented Aug 2, 2022

TL;DR

The Terraform Google Cloud Provider supports specifying availability_type for read replicas, but the module does not (see here).

This is a feature request to add the field for read replicas.

Terraform Resources

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/sql_database_instance#availability_type

Detailed design

I think this might just be as simple as adding `availability_type` to the https://github.com/terraform-google-modules/terraform-google-sql-db/blob/master/modules/postgresql/read_replica.tf#L38 resource.

Additional information

No response

@enocom enocom added the enhancement New feature or request label Aug 2, 2022
@g-awmalik g-awmalik added triaged Scoped and ready for work P2 high priority issues labels Aug 2, 2022
@g-awmalik
Copy link
Contributor

@enocom - is this request particularly for Postgres or for MySql as well?

@enocom
Copy link
Author

enocom commented Aug 3, 2022

Ideally all three engine types.

@g-awmalik
Copy link
Contributor

The PR is merged but we'll have a wait a bit for v12.0.0 because there's an upstream provider issue that is causing us to delay the release. If the fix isn't in early next week, we'll cut a release anyway. For now, feel free to pin it to master to get this feature.

@enocom
Copy link
Author

enocom commented Aug 4, 2022

Thanks @g-awmalik!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

2 participants