Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CloudSQL MySQL insights #347

Closed
bizrad opened this issue Sep 27, 2022 · 3 comments
Closed

Add support for CloudSQL MySQL insights #347

bizrad opened this issue Sep 27, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@bizrad
Copy link

bizrad commented Sep 27, 2022

TL;DR

Google has added query insights to the MySQL offering as well now.
Please add support for this in the mysql and safer_mysql modules.
Similar to #198 which was for postgres.

Terraform Resources

No response

Detailed design

No response

Additional information

Example detected changes when enabling this through the UI on an existing database using default options.

  # module.my-sql.module.safer_mysql.google_sql_database_instance.default has changed
  ~ resource "google_sql_database_instance" "default" {
        id                            = "my-db-a1a1a1a1"
        name                          = "my-db-a1a1a1a1"
        # (11 unchanged attributes hidden)

      ~ settings {
          ~ version               = 68 -> 71
            # (9 unchanged attributes hidden)

          + insights_config {
              + query_insights_enabled  = true
              + query_string_length     = 1024
              + record_application_tags = false
              + record_client_address   = false
            }

            # (4 unchanged blocks hidden)
        }

        # (1 unchanged block hidden)
    }
@bizrad bizrad added the enhancement New feature or request label Sep 27, 2022
@trajan0x
Copy link

+1 on this

@kpocius
Copy link
Contributor

kpocius commented Nov 8, 2022

This has been fixed and rolled out in 13.0.0 -- the issue can be closed.

@apeabody
Copy link
Contributor

apeabody commented Nov 8, 2022

Correct, Thanks!

@apeabody apeabody closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants