fix: Added sensitive field in output "primary" in mssql module #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tead of the whole version name for postgres module.
…tead of the whole version name for postgres module.
…tead of the whole version name for postgres module.
…e there are some sensitive fields in google_sql_database_instance resource.
…le, since there are some sensitive fields in google_sql_database_instance resource." This reverts commit 6c3aeef.
bharathkkb
changed the title
bharathkkb
approved these changes
Dec 17, 2022
|
@ravisiddhu no blockers to merge but our expectation is that these modules are used within root modules and not directly consumed. Consumers have full control over root modules to adjust the sensitivity of outputs |
|
@ravisiddhu |
ravisiddhu
added a commit
to ravisiddhu/terraform-google-sql-db
that referenced
this pull request
Dec 28, 2022
…form-google-modules#394) Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the issue mentioned in #364
Buganizer issue : (b/259913713): EXT: MSSQL output - We need to add sensitive = true for output "primary" on mssql module
Added sensitive field in output "primary" in mssql module, because google_sql_database_instance contains some sensitive fields.
Successfully passed docker_test_lint