Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ sensitive output safer mysql #401

Merged
merged 1 commit into from
Dec 29, 2022
Merged

feat: ✨ sensitive output safer mysql #401

merged 1 commit into from
Dec 29, 2022

Conversation

rs1986x
Copy link
Contributor

@rs1986x rs1986x commented Dec 29, 2022 •
edited
Loading

Hi!

I just simply added the sensitive = true parameter to the safer-mysql module as well

@rs1986x rs1986x requested a review from a team as a code owner December 29, 2022 11:08
@comment-bot-dev
Copy link

@rs1986x
Thanks for the PR! 🚀
✅ Lint checks have passed.

bharathkkb
bharathkkb approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rs1986x

@bharathkkb bharathkkb merged commit 5cc5e08 into terraform-google-modules:master Dec 29, 2022
@release-please release-please bot mentioned this pull request Dec 29, 2022
Merged
@rs1986x rs1986x deleted the sensitive-output-safer-mysql branch December 29, 2022 21:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@colmaustin-hw colmaustin-hw colmaustin-hw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rs1986x @comment-bot-dev @bharathkkb @colmaustin-hw