Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add deletion_protection.enabled for read replicas #437

Conversation

zculek-fb
Copy link
Contributor

Hello everyone,

At the moment, it is possible to fully protect only primary instances from accidental deletion across all surfaces (using deletion_protection.enabled. This addition will enable us to fully protect read replica instances as well, if needed.

@zculek-fb zculek-fb requested a review from a team as a code owner March 10, 2023 11:17
@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

1 similar comment
@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

/gcbrun

@zculek-fb
Copy link
Contributor Author

I do not have permissions to view why terraform-google-sql-db-int-trigger is failing:

You do not have sufficient permissions to view this page
There was an error while loading /cloud-build/builds/3b5adbc8-2e2d-4887-b7d7-932fe87b4976?project=2843445864.

The required permissions are:
Project 2843445864

cloudbuild.builds.get

So not sure if there's anything I need to fix or it's something else.

@apeabody
Copy link
Contributor

apeabody commented Mar 20, 2023

Retriggerd INT for fresh output.

I do not have permissions to view why terraform-google-sql-db-int-trigger is failing:

You do not have sufficient permissions to view this page
There was an error while loading /cloud-build/builds/3b5adbc8-2e2d-4887-b7d7-932fe87b4976?project=2843445864.

The required permissions are:
Project 2843445864

cloudbuild.builds.get

So not sure if there's anything I need to fix or it's something else.

Thanks for the contribution @zculek-fb. I'll re-trigger the INT for fresh output.

@apeabody
Copy link
Contributor

/gcbrun

@zculek-fb
Copy link
Contributor Author

Thanks! Can you please let me know what the error is as well, since I don't have permissions to view? Or at least point me to how to get needed permissions, if that's possible?

@apeabody
Copy link
Contributor

Hi @zculek-fb, certainly, it is:

Error: Error creating Database: googleapi: Error 409: Operation failed because another operation was already in progress. Try your request after the current operation is complete., operationInProgress

  with module.example.module.pg.google_sql_database.default[0],
  on ../../../modules/postgresql/main.tf line 174, in resource "google_sql_database" "default":
 174: resource "google_sql_database" "default" {
}

I'm re-triggering the INT test as it could be a race condition in the test.

@zculek-fb
Copy link
Contributor Author

Thanks again Andrew

Yeah, this doesn't look related to my code addition/changes. And it seems that the re-run did the trick - the INT check is passing now.

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik merged commit 4cdb81c into terraform-google-modules:master Apr 12, 2023
@zculek-fb zculek-fb deleted the add_deletion_protection_enabled_to_replica branch April 17, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants