-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add deletion_protection.enabled for read replicas #437
feat: Add deletion_protection.enabled for read replicas #437
Conversation
/gcbrun |
/gcbrun |
1 similar comment
/gcbrun |
/gcbrun |
I do not have permissions to view why terraform-google-sql-db-int-trigger is failing:
So not sure if there's anything I need to fix or it's something else. |
Retriggerd INT for fresh output.
Thanks for the contribution @zculek-fb. I'll re-trigger the INT for fresh output. |
/gcbrun |
Thanks! Can you please let me know what the error is as well, since I don't have permissions to view? Or at least point me to how to get needed permissions, if that's possible? |
Hi @zculek-fb, certainly, it is:
I'm re-triggering the INT test as it could be a race condition in the test. |
Thanks again Andrew Yeah, this doesn't look related to my code addition/changes. And it seems that the re-run did the trick - the INT check is passing now. |
/gcbrun |
Hello everyone,
At the moment, it is possible to fully protect only primary instances from accidental deletion across all surfaces (using deletion_protection.enabled. This addition will enable us to fully protect read replica instances as well, if needed.