Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Query Insights for MySQL for read replicas #453

Merged
merged 2 commits into from
Apr 17, 2023
Merged

feat: Support Query Insights for MySQL for read replicas #453

merged 2 commits into from
Apr 17, 2023

Conversation

smelchior
Copy link
Contributor

Adds support to enable query insights for mysql read replicas

@smelchior smelchior requested a review from a team as a code owner April 12, 2023 13:58
@google-cla
Copy link

google-cla bot commented Apr 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@smelchior smelchior changed the title Support Query Insights for MySQL for read replicas feat: Support Query Insights for MySQL for read replicas Apr 12, 2023
@g-awmalik
Copy link
Contributor

/gcbrun

@smelchior
Copy link
Contributor Author

@g-awmalik thanks for letting this run in the tests, i am not quite sure why it failed though as i can't see the logs. Is there anything I can do to make this work :)?

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

@g-awmalik thanks for letting this run in the tests, i am not quite sure why it failed though as i can't see the logs. Is there anything I can do to make this work :)?

Most likely a flaky test. I ran it again.

@smelchior
Copy link
Contributor Author

Ah that looks better, thanks :) Any chance to get this merged?

@g-awmalik g-awmalik merged commit 59b32af into terraform-google-modules:master Apr 17, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants