fix!: safer_mysql module's assign_public_ip
input should be bool type
#541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
the
safer_mysql
submodule'sassign_public_ip
's type isstring
, but default value isfalse
which is bool typeand this variable is used as bool parameter to
ip_configuration.ipv4_enabled
terraform-google-sql-db/modules/safer_mysql/main.tf
Line 54 in 5bcd8a4
but the ipv4_enabled is require bool type not string.
It also effects example mysql-private at
terraform-google-sql-db/examples/mysql-private/main.tf
Line 97 in 5bcd8a4
current action
if I run
terraform apply
in example/mysql-private , it will reject to run because of this wrong type.