Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dns_name to output in postgresql module #544

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

dkuji
Copy link
Contributor

@dkuji dkuji commented Nov 24, 2023

resolve: #524

@dkuji dkuji requested review from isaurabhuttam, imrannayer and a team as code owners November 24, 2023 07:47
@dkuji
Copy link
Contributor Author

dkuji commented Nov 29, 2023

@isaurabhuttam @imrannayer Good Day! can I get a review?

@imrannayer
Copy link
Collaborator

@dkuji thanks for the PR. Do we need this? We already have an output primary which has all the output of primary instance. You can grab DNS value from it.

@imrannayer imrannayer added the waiting-response Waiting for issue author to respond. label Dec 4, 2023
@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik g-awmalik merged commit 2ade7eb into terraform-google-modules:master Dec 5, 2023
4 checks passed
@imrannayer imrannayer removed the waiting-response Waiting for issue author to respond. label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dns_name missing from postgresql module outputs
3 participants