-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Allow passing ssl_mode for MySQL Module #575
feat!: Allow passing ssl_mode for MySQL Module #575
Conversation
69ce10d
to
7daac94
Compare
@davidcollom thx for the PR. Can you plz set min provider version to 5.7 as this feature was part of 5.6 and a fix for this was part of 5.7. |
Hey @imrannayer thanks for your quick response. As for postgresql I'm not sure, as I don't use this. As for the |
@imrannayer I've updated the |
/gcbrun |
@imrannayer - are you good with the changes? |
LGTM |
Hey @imrannayer @g-awmalik what's needed to get this merged in? All the CI has passed but pending code reviews. |
There is currently no way of passing the
ssl_mode
value from the module to thecloudsql_instance
resource.This PR aims to address this issue.