Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Allow passing ssl_mode for MySQL Module #575

Conversation

davidcollom
Copy link
Contributor

There is currently no way of passing the ssl_mode value from the module to the cloudsql_instance resource.

This PR aims to address this issue.

@davidcollom davidcollom force-pushed the allow-passing-ssl_mode-mysql branch from 69ce10d to 7daac94 Compare February 6, 2024 15:58
@imrannayer imrannayer changed the title Allow passing ssl_mode for MySQL Module feat: Allow passing ssl_mode for MySQL Module Feb 6, 2024
@imrannayer
Copy link
Collaborator

@davidcollom thx for the PR. Can you plz set min provider version to 5.7 as this feature was part of 5.6 and a fix for this was part of 5.7.
Can you plz add it to safer_mysql module?
Also if this is this something needed for postgres, can u plz add it to postgres modules?

@davidcollom
Copy link
Contributor Author

Hey @imrannayer thanks for your quick response.

As for postgresql I'm not sure, as I don't use this.

As for the safer_mysql module... Would you expect TRUSTED_CLIENT_CERTIFICATE_REQUIRED to be enforced? Or default? As this imo would be the "safest default value"..or would/should we fall back to the providers default?

@davidcollom
Copy link
Contributor Author

@imrannayer I've updated the safer_mysql module, and checked the postgresql module, which already includes this feature, which was added here: 9c59232

@g-awmalik
Copy link
Contributor

/gcbrun

@g-awmalik
Copy link
Contributor

@imrannayer - are you good with the changes?

@imrannayer
Copy link
Collaborator

LGTM

@davidcollom
Copy link
Contributor Author

davidcollom commented Feb 7, 2024

Hey @imrannayer @g-awmalik what's needed to get this merged in? All the CI has passed but pending code reviews.

@g-awmalik g-awmalik changed the title feat: Allow passing ssl_mode for MySQL Module feat!: Allow passing ssl_mode for MySQL Module Feb 7, 2024
@g-awmalik g-awmalik merged commit c7ab6ec into terraform-google-modules:master Feb 7, 2024
4 checks passed
@davidcollom davidcollom deleted the allow-passing-ssl_mode-mysql branch February 8, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants