Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mssql - make instance_server_ca_cert output sensitive #609

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

VladStarr
Copy link
Contributor

@VladStarr VladStarr commented Jun 6, 2024

Changed the mssql module output instance_server_ca_cert to be marked as sensitive.
This change should fix the following error:

│ Error: Output refers to sensitive values
│ 
│   on outputs.tf line 48:
│   48: output "instance_server_ca_cert" {
│ 
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│ 
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│     sensitive = true

@VladStarr VladStarr requested review from isaurabhuttam, imrannayer and a team as code owners June 6, 2024 07:57
Copy link

google-cla bot commented Jun 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@imrannayer imrannayer changed the title mssql: make instance_server_ca_cert output sensitive fix: mssql - make instance_server_ca_cert output sensitive Jun 6, 2024
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer self-assigned this Jun 6, 2024
@imrannayer imrannayer merged commit 163a89c into terraform-google-modules:master Jun 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants