feat!: Add enable_google_ml_integration setting for database instance and configurable project roles for default database service account #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
bharathkkb
changed the title
…d confirable project roles for default database service account
q2w
force-pushed
the
feature/postgresql_ml_integration
branch
from
cae940d to
a1ea3d4
Compare
|
/gcbrun |
bharathkkb
approved these changes
Jul 10, 2024
|
/gcbrun |
1 similar comment
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes below changes,
enable_google_ml_integrationsetting for database instance. https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/sql_database_instance#enable_google_ml_integrationThis feature has been used in "Gen AI rag with cloud sql" https://github.com/GoogleCloudPlatform/terraform-genai-rag/blob/main/database.tf#L32