fix!: Cleanup of old instance backups. Change role roles/cloudsql.editor to roles/cloudsql.admin #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts the change to using the cloudsql.editor role for the backup service account from the cloudsql.admin role. This was introduced in terraform-google-modules#597 but due to this the deletion of old backups on the instance now receives a 403 error in the workflow. This is due to the fact that the cloudsql.editor role lacks the cloudsql.backupRuns.delete permission. Closes: terraform-google-modules#617
tjespers
requested review from
isaurabhuttam,
imrannayer and
a team
as code owners
|
/gcbrun |
imrannayer
changed the title
imrannayer
changed the title
|
/gcbrun |
imrannayer
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts the change to using the cloudsql.editor role
for the backup service account from the cloudsql.admin role. This was
introduced in #597 but due to this the deletion of old backups on the
instance now receives a 403 error in the workflow. This is due to the
fact that the cloudsql.editor role lacks the cloudsql.backupRuns.delete
permission.
Closes: #617