Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TPG>5.38)!: added deletion_policy to private service access sub-module and promoted to GA provider #620

Merged
merged 4 commits into from
Jul 23, 2024
Merged

feat(TPG>5.38)!: added deletion_policy to private service access sub-module and promoted to GA provider #620

merged 4 commits into from
Jul 23, 2024

Conversation

imrannayer
Copy link
Collaborator

@imrannayer imrannayer commented Jul 16, 2024 •
edited
Loading

Fix #585

  • Add deletion_policy to private service access sub-module
  • Moved private service access sub-module to GA provider (TPG >=5.33)
  • Fixed tests: Reduce number of cpu/memory to avoid running out of quota
  • Fixed workflow service agent error in test

@imrannayer imrannayer requested review from isaurabhuttam and a team as code owners July 16, 2024 20:44
@imrannayer imrannayer self-assigned this Jul 16, 2024
@imrannayer imrannayer changed the title feat(TPG>5.38)!: added deletion_policy to private service access sub-module feat(TPG>5.38)!: added deletion_policy to private service access sub-module and promoted to GA provider Jul 16, 2024
@imrannayer
Copy link
Collaborator Author

/gcbrun

This was referenced Jul 17, 2024
Merged
Merged
@imrannayer
Copy link
Collaborator Author

@bharathkkb plz review

@imrannayer imrannayer merged commit cf5f184 into terraform-google-modules:master Jul 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-awmalik g-awmalik g-awmalik approved these changes

@isaurabhuttam isaurabhuttam Awaiting requested review from isaurabhuttam

Assignees

@bharathkkb bharathkkb

@imrannayer imrannayer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add field deletion_policy to google_service_networking_connection in modules/private_service_access
3 participants
@imrannayer @g-awmalik @bharathkkb