Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add connection metadata, output and support for ml integration for Mysql module #637

Merged

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Sep 2, 2024

This PR makes similar changes (listed below) which has been made to postgresql module. The PR adds connection metadata, a new output variable called env_vars and support for enabling ml_integration

  1. 441bc2d
  2. f02e3fd
  3. 83bbaa3

@q2w q2w force-pushed the chore/connection-metadata branch from 9f07177 to 46b4212 Compare September 2, 2024 06:52
@q2w q2w changed the title Chore/connection metadata chore: Add connection metadata, output and support for ml integration for Mysql module Sep 2, 2024
@q2w q2w requested a review from bharathkkb September 2, 2024 08:26
@q2w q2w marked this pull request as ready for review September 2, 2024 08:28
@q2w q2w requested review from isaurabhuttam, imrannayer and a team as code owners September 2, 2024 08:28
@q2w
Copy link
Collaborator Author

q2w commented Sep 2, 2024

/gcbrun

@bharathkkb bharathkkb changed the title chore: Add connection metadata, output and support for ml integration for Mysql module feat!: Add connection metadata, output and support for ml integration for Mysql module Sep 3, 2024
@bharathkkb
Copy link
Member

Marking as breaking due to min provider bump

Makefile Outdated Show resolved Hide resolved
@bharathkkb bharathkkb merged commit f2c91fa into terraform-google-modules:master Sep 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants